Cloudy & Associates

  1. 20 Nov, 2021 4 commits
    • Ferland, Gary's avatar
      Merge branch 'garciaoi' · 82784b7b
      Ferland, Gary authored
    • Robin Williams's avatar
      Merge branch 'issue_437' into 'master' · 06fd12cb
      Robin Williams authored
    • Robin Williams's avatar
      Fix crash on erroneous input · 79aaf978
      Robin Williams authored
      See issue #437 for details
    • Ferland, Gary's avatar
      update OI CS per Antonio Garcia report · a3827c18
      Ferland, Gary authored
      email of 2021 May 5
      In the last few days, I've been collecting rates for
      O i +e inelastic collisions. I started with Barklem,
      A&A 462, 781-788 (2007) and tried to cast the rates into
      Omega_ij strengths. After accounting for the partitioning
      into the 3 fine-structure levels (lumped together by
      Barklem), I was in a position to compare my Omega_ij with
      those reported in the stout datafile. I was able to match
      the Omega_ij for all transitions from the 1,2,3 levels
      into the 4,5,6 levels, and also the 4-->5 transition.
      I'm not able, however, to reproduce the Omega_ij values reported
      in stout for the 1,2,3-->7 transition (from O(3P_J=2,1,0)
      into the level at 9.52 eV). I didn't check the transitions
      into more energetic states. The comments at the bottom of the
      stout o_1.coll file (attached here for your reference) note
      that there may be some inconsistencies. I'm also attaching the
      values that I estimated myself for transitions within levels up
      to 10 eV. I would appreciate your comments on this difference.
      If you think it may be useful, I can send you a more extended
      table with the Omega_ij for additional transitions.
      Thank you!
         Antonio García Muñoz
      Dr. Habil.
      Planetary/Atmospheric Scientist
      CEA Paris-Saclay
      Bât. 703 Orme des Merisiers
      91191 Gif-sur-Yvette Cedex, France
  2. 13 Nov, 2021 1 commit
  3. 12 Nov, 2021 2 commits
  4. 04 Nov, 2021 2 commits
  5. 03 Nov, 2021 1 commit
  6. 02 Nov, 2021 3 commits
  7. 29 Oct, 2021 3 commits
  8. 28 Oct, 2021 3 commits
    • Marios Chatzikos's avatar
      Fix typo in comment · 644a6799
      Marios Chatzikos authored
    • Ferland, Gary's avatar
      GS correct errors recently introduced reactions · 9a72cd25
      Ferland, Gary authored
      The form of th85rate has a different formula than hmrate. For photoreactions one should use th85rate, not the hmrate. Since, both the th85rate and hmrate  take coefficient values in a similar syntax style (for alpha, beta and gamma), an unintentional mistake happened by me for those reactions.
    • Ferland, Gary's avatar
      series of missed SPECIES => DATABASE in docs · 5818af33
      Ferland, Gary authored
      The SPECIES command still used in some error messages
      when the SPECIES command changed to DATABASE
      Same mistake in doc for commands with VARY option
  9. 26 Oct, 2021 1 commit
  10. 25 Oct, 2021 1 commit
    • Marios Chatzikos's avatar
      Fix bug in statistical weight of singlet ground · 9cd3a14a
      Marios Chatzikos authored
      The function that computes the statistical weight for levels in He-like
      species reports 4n^2 for all levels.  The 4 sums over both singlets and
      triplets.  However, the ground has only a singlet state, no triplet.
      This is the corollary of an earlier bug, which made the same mistake in
      how the n-n' CS is broken up among the fine structure levels of a He-like
      ground state.
  11. 23 Oct, 2021 1 commit
  12. 22 Oct, 2021 5 commits
  13. 21 Oct, 2021 1 commit
    • Marios Chatzikos's avatar
      Fix bug in H2 line cooling · 96bb6596
      Marios Chatzikos authored
      Priyanka reported a floating point exception abort in one of her runs.
      It came from a straight-up division in CoolH2_GA08.
      Enclose all divisions in that function in safe_div calls.
  14. 20 Oct, 2021 1 commit
  15. 19 Oct, 2021 3 commits
  16. 18 Oct, 2021 1 commit
    • Marios Chatzikos's avatar
      Fix bug in statistical weight of He-like ground · 5f8e92f4
      Marios Chatzikos authored
      The present coding effectively assumes that both singlets and triplets
      are present in the ground of He-like ions, when in reality the ground
      is a singlet.
      The He-like ground now has a statistical weight of 1.  Fixed.
  17. 15 Oct, 2021 1 commit
    • Marios Chatzikos's avatar
      Fix bug with FeII bands and consolidate classes · 190b1b88
      Marios Chatzikos authored
      Hazy claims that the FeII bands are always processed, but this happens
      only if a 'save' command has been given.  Move the command that enters
      the FeII bands onto the stack of bands to be processed to the top of
      SpeciesBandsCreate(), to make sure they are always added.
      The 'save species bands' infrastructure uses two classes to store info
      for each instance of the command.  The bands file and the species name
      are stored as part of the t_save struct, while the data for summing the
      band emission are stored in species_pseudo_cont.cpp.  Refactor the code
      so that only one class exists that holds as data the parsed info as well
      as an object of the class that sums up the emission.
  18. 14 Oct, 2021 2 commits
  19. 12 Oct, 2021 1 commit
    • Marios Chatzikos's avatar
      Fix bug with command order and 'save species bands' · e47ba38c
      Marios Chatzikos authored
      Gary sent a bug report that triggered an error with setting up the
      "FeII_bands.ini" file in a sim that contained a 'save' command, and
      'init "honly.ini"', in that order.
      The problem occurred because ParseSave() specified "FeII_bands.ini" for
      loading.  Iron was disabled later, so the "Fe+" species was not entered
      in the list of species known to the code.  This triggered an abort when
      the code tried to set up the FeII bands.
      Make sure that the species is active before attempting to set up bands.
      This requires that the bands are initialized after the atomic data have
      been read in -- the relevant calls have been moved to cloudy().
      The initialization of pseudo continua has also been moved to cloudy(),
      for symmetry.
  20. 05 Oct, 2021 1 commit
  21. 04 Oct, 2021 2 commits