Cloudy & Associates

  1. 04 Jun, 2022 1 commit
  2. 03 Jun, 2022 4 commits
    • Chatzikos, Marios's avatar
      Clarify header of 'save fine continuum' · 1de9b393
      Chatzikos, Marios authored
      Previously, the header produced by the command used the words 'Species'
      and 'Opt Dep Spec'.  The former is outdated, given that we now report
      the spectral line label (including wavelength), and the latter is not
      clear to the user, given that we refer to the single-line optical depth
      as Specific only in the source.
      
      Here, the former is replaced with 'SpecLine' and the latter with
      'Single Line Opt Depth'.
      1de9b393
    • Chatzikos, Marios's avatar
      Remove limit from code block in LineStackCreate() · 2a204d19
      Chatzikos, Marios authored
      The previous implementation of the code block in LineStackCreate() that
      quantifies line overlap used an arbitrary value of 20 as the maximum
      number of lines that could overlap in a bin.
      
      During review, Gary questioned the choice.  This ad hoc value was picked
      as a high enough limit to carry out the task, given that currently up to
      14 lines overlap in a bin.
      
      The previous implementation was also inefficient in that it went over
      rfield.fine_lstack map several times to produce the report.
      
      Here, the overlap across rfield.fine_lstack is established ahead of
      time, and each fine continuum index in the map is visited only once for
      the report.  The ad hoc value of 20 is removed.
      2a204d19
    • Chatzikos, Marios's avatar
      Add comment to code block in LineStackCreate() · 85b6a75f
      Chatzikos, Marios authored
      A (disabled) block of code was added at the end of LineStackCreate()
      that worked its way through the map of fine continuum bins and line
      stack indices to quantify the amount of overlap present.  The block
      did not carry a comment.  During review, it was deemed necessary to
      explain its intent.  This is done here.
      
      Also, on the output of bins with overlap greater than 10 lines, the
      line stack index is now reported to show that the repeating species
      labels are indeed genuine.
      85b6a75f
    • Chatzikos, Marios's avatar
      eb671072
  3. 02 Jun, 2022 3 commits
  4. 28 May, 2022 2 commits
    • Chatzikos, Marios's avatar
      Merge branch 'prep-release' into 'master' · ebd1ad4e
      Chatzikos, Marios authored
      Update scripts and source for release preparation
      
      See merge request !36
      ebd1ad4e
    • Chatzikos, Marios's avatar
      Report full line label in 'save fine continuum' · beea18d7
      Chatzikos, Marios authored
      The previous implementation reported only a feature's species in
      spectral notation, e.g., 'Fe17'.
      
      This is useful if cells are not merged and the energy is reported in
      wavelength units (say, Angstrom), because the exact wavelength is
      reported in the first column.
      
      Merging cells eliminates the wavelength information, and if the number
      of cells merged together is high, the output can be confusing.
      
      Report the entire spectral label, including the wavelength, to eliminate
      ambiguity in the output.
      beea18d7
  5. 27 May, 2022 3 commits
    • Chatzikos, Marios's avatar
      Report all opaque lines in 'save fine continuum' · 4307a8b4
      Chatzikos, Marios authored
      The previous implementation reported only the most opaque line per bin.
      Merging cells may eliminate important lines from the output.
      
      All lines contributing opacity to a cell are now reported, if their
      optical depth exceeds a limit.
      4307a8b4
    • Chatzikos, Marios's avatar
      Eliminate code duplication in 'save fine cont' · 89b5afdf
      Chatzikos, Marios authored
      The previous implementation of 'save fine continuum' accumulated the
      first bin separately from any requested others (9 more, by default).
      That forced code duplication relating to identifying the most opaque
      line in the bin.
      
      Restructure the code to treat all bins at once; eliminate duplication.
      89b5afdf
    • Chatzikos, Marios's avatar
      Identify most opaque line in 'save fine continuum' · d1073383
      Chatzikos, Marios authored
      Anna Ogorzalek posted a query on the Cloudy group about identifying
      absorption features in the output of the 'save xspec mtable' command.
      
      A partial answer would be to identify features due to the lines alone.
      
      The present adds two columns to the output of 'save fine continuum'.
      The first identifies the species whose line is centered at that bin,
      and the second reports the optical depth due that line alone (i.e., not
      the total including any neighboring lines).
      d1073383
  6. 19 May, 2022 1 commit
  7. 27 Apr, 2022 1 commit
    • Ferland, Gary's avatar
      demote cautions of parts of SED being zero to notes · ce780fa2
      Ferland, Gary authored
      The demotes cautions that parts of the SED are zero to notes.
      The following wc on auto shows that we have a large number of
      these.  They are benign - they occur if we use a blackbody
      that does go to zero far out in the Wien tail.  They are a
      minor note about the SED rather than something deserving of
      raising a caution.
      
      the number of cautions in tsuite/auto went from
      
      Alien20:auto:wc ~gary/cloudy/cautions.txt
        5267  72721 544951 /home/gary/cloudy/cautions.txt
      
      to
      
      Alien20:auto:wc cautions2.txt
        3846  64015 460146 cautions2.txt
      ce780fa2
  8. 15 Apr, 2022 1 commit
  9. 14 Apr, 2022 17 commits
  10. 13 Apr, 2022 3 commits
  11. 12 Apr, 2022 3 commits
  12. 11 Apr, 2022 1 commit