... | @@ -73,7 +73,7 @@ for fixing it. 08 March 22. |
... | @@ -73,7 +73,7 @@ for fixing it. 08 March 22. |
|
|
|
|
|
----
|
|
----
|
|
|
|
|
|
The *_code could fail with internal insanity if the resolution of the continuum mesh, as defined in continuum_mesh.dat is made very fine*_. This is caused by a round-off error in the floating-point numbers. If you need to use a very fine continuum mesh and encounter this problem you should make this fix. Edit routine cont_setintensity.cpp and change the code at line 201 to read as follows:
|
|
The *code could fail with internal insanity if the resolution of the continuum mesh, as defined in continuum_mesh.dat is made very fine*. This is caused by a round-off error in the floating-point numbers. If you need to use a very fine continuum mesh and encounter this problem you should make this fix. Edit routine cont_setintensity.cpp and change the code at line 201 to read as follows:
|
|
|
|
|
|
```
|
|
```
|
|
rfield.anu[i] = (float)(amean2/amean);
|
|
rfield.anu[i] = (float)(amean2/amean);
|
... | @@ -91,8 +91,8 @@ The first and last lines are not changed - the if block is the patch code. This |
... | @@ -91,8 +91,8 @@ The first and last lines are not changed - the if block is the patch code. This |
|
|
|
|
|
----
|
|
----
|
|
|
|
|
|
The *_recombination intensity of O II 4651*_ was not included in the transferred lines
|
|
The *recombination intensity of O II 4651* was not included in the transferred lines
|
|
and so *_would appear with zero intensity*_ under some conditions.
|
|
and so *would appear with zero intensity* under some conditions.
|
|
To fix edit routine prt_lines_lv1_li_ne.cpp and change lines around 913-916 to read as follows:
|
|
To fix edit routine prt_lines_lv1_li_ne.cpp and change lines around 913-916 to read as follows:
|
|
|
|
|
|
```
|
|
```
|
... | @@ -107,7 +107,7 @@ out this problem. 2007 Dec 09 |
... | @@ -107,7 +107,7 @@ out this problem. 2007 Dec 09 |
|
|
|
|
|
----
|
|
----
|
|
|
|
|
|
If you include either the command *_grains vary*_ or *_grains "some_file.opc" vary*_, or some variation thereof, the run would crash on a TotalInsanity. This is caused by a broken test if a variable was initialized. The hot fix is to edit parse_grain.cpp and simply delete the following test:
|
|
If you include either the command *grains vary* or *grains "some_file.opc" vary*, or some variation thereof, the run would crash on a TotalInsanity. This is caused by a broken test if a variable was initialized. The hot fix is to edit parse_grain.cpp and simply delete the following test:
|
|
|
|
|
|
```
|
|
```
|
|
367 : if( length == 0 )
|
|
367 : if( length == 0 )
|
... | @@ -118,7 +118,7 @@ Problem reported by Enrique Pérez Montero. 2007 Dec 07 |
... | @@ -118,7 +118,7 @@ Problem reported by Enrique Pérez Montero. 2007 Dec 07 |
|
|
|
|
|
----
|
|
----
|
|
|
|
|
|
A *_bug in the calculation of stark broadening*_ caused escape probabilities for lines from Rydberg levels to be underestimated. To correct, edit iso_create.cpp at line 367. The source should be changed to the following:
|
|
A *bug in the calculation of stark broadening* caused escape probabilities for lines from Rydberg levels to be underestimated. To correct, edit iso_create.cpp at line 367. The source should be changed to the following:
|
|
|
|
|
|
```
|
|
```
|
|
else
|
|
else
|
... | @@ -153,7 +153,7 @@ That is, change [ion] to [ion-1]. Many thanks to R. Surendiranath for uncoverin |
... | @@ -153,7 +153,7 @@ That is, change [ion] to [ion-1]. Many thanks to R. Surendiranath for uncoverin |
|
|
|
|
|
----
|
|
----
|
|
|
|
|
|
In *FITS files produced for use in XSPEC*, logarithmic interpolation was specified. This caused *_problems for negative values*_ since the log of a negative number is undefined. Ideally, there would be a command-line option to specify the interpolation method, but for now, we just switch the hard-wired specification to linear interpolation. The effect is, of course, negligible for a sufficiently resolved grid with positive parameter values. Line 75 of grid_xspec.cpp should be changed from this
|
|
In *FITS files produced for use in XSPEC*, logarithmic interpolation was specified. This caused *problems for negative values* since the log of a negative number is undefined. Ideally, there would be a command-line option to specify the interpolation method, but for now, we just switch the hard-wired specification to linear interpolation. The effect is, of course, negligible for a sufficiently resolved grid with positive parameter values. Line 75 of grid_xspec.cpp should be changed from this
|
|
grid.paramMethods[i] = 1;
|
|
grid.paramMethods[i] = 1;
|
|
to this
|
|
to this
|
|
grid.paramMethods[i] = 0;
|
|
grid.paramMethods[i] = 0;
|
... | @@ -170,7 +170,7 @@ Thanks to Bryan Armentrout for pointing out this issue. 2007 Sep 4. |
... | @@ -170,7 +170,7 @@ Thanks to Bryan Armentrout for pointing out this issue. 2007 Sep 4. |
|
|
|
|
|
[Unix patch](http://data.nublado.org/cloudy_releases/c07_02/hotfixes/)
|
|
[Unix patch](http://data.nublado.org/cloudy_releases/c07_02/hotfixes/)
|
|
|
|
|
|
Thomas Rauch has recently *_updated his hydrogen-only grid*_. The test in the auto test suite was still based on the previous version of the grid. Using the *_new grid with the existing test case will yield botched asserts*_. This is not a problem in the code, but simply reflects the fact that we were still testing the older grid. In order to fix the botched asserts, change the following asserts in the file stars_rauch_hydr.in:
|
|
Thomas Rauch has recently *updated his hydrogen-only grid*. The test in the auto tsuite was still based on the previous version of the grid. Using the *new grid with the existing test case will yield botched asserts*. This is not a problem in the code, but simply reflects the fact that we were still testing the older grid. In order to fix the botched asserts, change the following asserts in the file stars_rauch_hydr.in:
|
|
|
|
|
|
```
|
|
```
|
|
// >>chng 07 jul 16, from -2.3007 to -2.2862, update Rauch atmospheres
|
|
// >>chng 07 jul 16, from -2.3007 to -2.2862, update Rauch atmospheres
|
... | @@ -254,7 +254,7 @@ In the next version, we will also print -30.0 instead of 0.0 for small columns. |
... | @@ -254,7 +254,7 @@ In the next version, we will also print -30.0 instead of 0.0 for small columns. |
|
|
|
|
|
-----
|
|
-----
|
|
|
|
|
|
In ion_recomb_Badnell.cpp, *_two while loops occasionally caused an array bounds to be exceeded*_. The following lines two lines are added just below "--nn_counter[z_value][n_value];" at lines 492 and 530:
|
|
In ion_recomb_Badnell.cpp, *two while loops occasionally caused an array bounds to be exceeded*. The following lines two lines are added just below "--nn_counter[z_value][n_value];" at lines 492 and 530:
|
|
if( nn_counter[z_value][n_value] < 0 )
|
|
if( nn_counter[z_value][n_value] < 0 )
|
|
break;
|
|
break;
|
|
|
|
|
... | @@ -266,7 +266,7 @@ Photoexcitation of upper levels of split ground terms by the UV radiation field |
... | @@ -266,7 +266,7 @@ Photoexcitation of upper levels of split ground terms by the UV radiation field |
|
|
|
|
|
-----
|
|
-----
|
|
|
|
|
|
The *set atomic data* command now has the option *_sulphur DR*_ to change the treatment of S dielectronic recombination. This change was merged into the C07.02.01 release. The guesses which are used when no DR data are available are now the mean of the logs of the DR rates. This is better due to the large dispersion in rate coefficients. Accurate DR rates do not now exist for low stages of ionization of S at photoionization temperatures. The relative [S III] / [S II] ratio is an important diagnostic indicator of conditions in many nebulae. This ratio depends on the DR rates chosen. This command changes the DR rates assumed for the lowest four ionization stages of S. The default, which can also be set with the keyword *__mix*_, is to use the larger of the Badnell (1991; ApJ, 379, 356 ) or guessed rates. The keyword *_pure*_ says to use only the Badnell rates. The keyword *_scale*_ says to use scaled oxygen DR rates. In this case one to four scale factors, one for each ionization stage, will be parsed off the command line. If fewer than four numbers occur then the last number entered will be used for the missing scale factors. The DR rate for ions of S will be equal to the DR rate for the same ionization stage of O multiplied by its scale factor.
|
|
The *set atomic data* command now has the option *sulphur DR* to change the treatment of S dielectronic recombination. This change was merged into the C07.02.01 release. The guesses which are used when no DR data are available are now the mean of the logs of the DR rates. This is better due to the large dispersion in rate coefficients. Accurate DR rates do not now exist for low stages of ionization of S at photoionization temperatures. The relative [S III] / [S II] ratio is an important diagnostic indicator of conditions in many nebulae. This ratio depends on the DR rates chosen. This command changes the DR rates assumed for the lowest four ionization stages of S. The default, which can also be set with the keyword *mix*, is to use the larger of the Badnell (1991; ApJ, 379, 356 ) or guessed rates. The keyword *pure*_ says to use only the Badnell rates. The keyword *_scale*_ says to use scaled oxygen DR rates. In this case one to four scale factors, one for each ionization stage, will be parsed off the command line. If fewer than four numbers occur then the last number entered will be used for the missing scale factors. The DR rate for ions of S will be equal to the DR rate for the same ionization stage of O multiplied by its scale factor.
|
|
|
|
|
|
-----
|
|
-----
|
|
|
|
|
... | | ... | |