H atom continuum pumping does not reproduce
in the valentina models she tried these two commands:
pumpoff.in
atom h-like lyman pumping off
hydro.lgLymanPumping
pumpscale.in
atom h-like lyman pumping scale 0
hydro.xLymanPumpingScaleFactor
these should have the same effect but don't - she asked about this on the yahoo site. The two sims are attached.
the active command is given above and the variable it sets is below the command. They do not use the same variable, a design flaw.
why don't they produce identical effects? I have gone over where they are used and found one bug - the upper level is 1 for hydro.lgLymanPumping but is 2 for hydro.xLymanPumpingScaleFactor
I propose changing the 2 to 1 in iso_solve.cpp:66 and 384
even with this change the output of the two sims is not the same. there must be other problems.
this change causes a few blr fail to fail monitors on my mac. H I Pa in one. I have not made the change in the repo since there is clearly more going on than I understand right now.