|
|
|
|
|
# Hot fixes to C05.07
|
|
|
|
|
|
------
|
|
|
|
|
|
The *_array index for the Rauch 2002 stellar atmospheres is incorrect*_ when the default is used. To fix, edit stars_rauch02.c and change line 802 so that it sets ipTeff to 14 rather than 23. After the correction the line will read as follows:
|
|
|
The *array index for the Rauch 2002 stellar atmospheres is incorrect* when the default is used. To fix, edit stars_rauch02.c and change line 802 so that it sets ipTeff to 14 rather than 23. After the correction the line will read as follows:
|
|
|
|
|
|
```
|
|
|
if( tval[NTVAL-1] == temp_star )
|
... | ... | @@ -17,7 +15,7 @@ Many thanks to Marcin Hajduk for finding this problem. 2006 Feb 08. |
|
|
|
|
|
------
|
|
|
|
|
|
The *_continuum array could have insane energies*_ when the continuum intensity changes dramatically at certain energies. When this occurs the code will stop and declare insanity. To fix, edit cont_setintensity.c and add an if test following line 156. After the change the code (including two lines before and one line after the change) will read
|
|
|
The *continuum array could have insane energies*_when the continuum intensity changes dramatically at certain energies. When this occurs the code will stop and declare insanity. To fix, edit cont_setintensity.c and add an if test following line 156. After the change the code (including two lines before and one line after the change) will read
|
|
|
|
|
|
```
|
|
|
wanu[j] = MAX2( wanu[j] , rfield.emm );
|
... | ... | @@ -38,7 +36,7 @@ Many thanks to Sergio Fajardo-Acosta for reporting this problem. 06 Feb 03. |
|
|
|
|
|
-----
|
|
|
|
|
|
The *_optimize temperatures command only recognized the keyword VOLUME and not volume*_. Change the variable chCard to chCap on line 598 of parse_optimze.c. After the change the line and the one before it will read
|
|
|
The *optimize temperatures command only recognized the keyword VOLUME and not volume*. Change the variable chCard to chCap on line 598 of parse_optimze.c. After the change the line and the one before it will read
|
|
|
|
|
|
```
|
|
|
strcpy( optimize.chTempWeight[optimize.nTempObs] , "radius" );
|
... | ... | @@ -50,7 +48,7 @@ Many thanks to Bohdan Melekh for finding and fixing this problem. 05 Dec 29 |
|
|
|
|
|
-----
|
|
|
|
|
|
The *_recombination contribution to [N II] l5755 was incorrect*_. Equation 1 from Liu et al. MNRAS 312, 585 was written in terms of the temperature scaled to 1e4 K. The code works in terms of the real temperature so the rate was too large by a factor of 1e4^0.3 or 15.8489. To fix this edit routine prt_lines_lv1_li_ve.c and change the code near line 365 to read as follows:
|
|
|
The *recombination contribution to [N II] l5755 was incorrect*. Equation 1 from Liu et al. MNRAS 312, 585 was written in terms of the temperature scaled to 1e4 K. The code works in terms of the real temperature so the rate was too large by a factor of 1e4^0.3 or 15.8489. To fix this edit routine prt_lines_lv1_li_ve.c and change the code near line 365 to read as follows:
|
|
|
|
|
|
```
|
|
|
/*>>chng 05 dec 16, Liu et al. (2000) eqn 1 uses t = Te/10^4 K, not Te so phycon.te30
|
... | ... | @@ -63,7 +61,7 @@ Many thanks to Kevin Blagrave for finding and fixing this problem. 05 Dec 15 |
|
|
|
|
|
-----
|
|
|
|
|
|
The code can *_crash with an fpe for very density models*_. To fix, edit routine helike_level.c, and change line 783, variable iso.numLevels[ipHE_LIKE][nelem] to helike.numLevels[nelem]. After the change the code around this line will read:
|
|
|
The code can *crash with an fpe for very density models*. To fix, edit routine helike_level.c, and change line 783, variable iso.numLevels[ipHE_LIKE][nelem] to helike.numLevels[nelem]. After the change the code around this line will read:
|
|
|
```
|
|
|
|
|
|
/* Along the iso-sequence, two of the 2^3Pj terms are always very nearly degenerate, these
|
... | ... | @@ -80,7 +78,7 @@ Many thanks to Kirk Korista for reporting this problem. 05 Nov 18. |
|
|
|
|
|
-----
|
|
|
|
|
|
The *_grain emission continuum predicted by the punch grain continuum command is incorrect*_ on second and later iterations. The storage arrays need to be reset to zero. Correct this by adding the following loop after line 314 of grains.c - after the correction the code will appear as follows:
|
|
|
The *grain emission continuum predicted by the punch grain continuum command is incorrect* on second and later iterations. The storage arrays need to be reset to zero. Correct this by adding the following loop after line 314 of grains.c - after the correction the code will appear as follows:
|
|
|
|
|
|
```
|
|
|
if( gv.lgDustOn && gv.lgGrainPhysicsOn )
|
... | ... | @@ -99,11 +97,11 @@ for( nd=0; nd < gv.nBin; nd++ ) |
|
|
* save grain potential */
|
|
|
```
|
|
|
|
|
|
This only affects the punch grain continuum command. Many thanks to John Everett for discovering this problem. 05 Sep 08
|
|
|
This only affects the *punch grain continuum* command. Many thanks to John Everett for discovering this problem. 05 Sep 08
|
|
|
|
|
|
-----
|
|
|
|
|
|
An *_assert could be thrown for cases where the He++ abundance became very small*_. Edit routine radius_increment.c and change ERR_CHK at line 112 from 1.001 to 1.01. After the change the line will read as follows:
|
|
|
An *assert could be thrown for cases where the He++ abundance became very small*. Edit routine radius_increment.c and change ERR_CHK at line 112 from 1.001 to 1.01. After the change the line will read as follows:
|
|
|
|
|
|
```
|
|
|
/* >>chng 05 feb 05, for very highly ionized sims, where N or O is He-like,
|
... | ... | @@ -122,7 +120,7 @@ Many thanks to Yoshiki Matsuoka and Carmen Sanchez Contrera for reporting this p |
|
|
|
|
|
-----
|
|
|
|
|
|
The *_set spectrum command incorrectly raised its argument to a power*_. This results in an FPE for reasonable resolving power. If you wish to use this command then file routine parse_set.c and change line 647 from the following:
|
|
|
The *set spectrum command incorrectly raised its argument to a power*. This results in an FPE for reasonable resolving power. If you wish to use this command then file routine parse_set.c and change line 647 from the following:
|
|
|
|
|
|
```
|
|
|
i = 5;
|
... | ... | @@ -156,11 +154,11 @@ punch.cp_range_max[punch.cp_npun] = (float)FFmtRead(chCard,&i,INPUT_LINE_LENGTH, |
|
|
|
|
|
Note that this command accepts only the energy in Rydbergs.
|
|
|
|
|
|
This only affect the set spectrum commands. Many thanks to Yan Changshou for reporting this problem. 05 Aug 25
|
|
|
This only affects the set spectrum commands. Many thanks to Yan Changshou for reporting this problem. 05 Aug 25
|
|
|
|
|
|
-----
|
|
|
|
|
|
An *_incorrect array index is used to zero a continuum array*_. Edit parse_interp.c lines 402-404, which originally read as
|
|
|
An *incorrect array index is used to zero a continuum array*. Edit parse_interp.c lines 402-404, which originally read as
|
|
|
|
|
|
```
|
|
|
/* zero out remainder of array */
|
... | ... | @@ -206,8 +204,8 @@ This has no effect on results but will cause thrown asserts on some systems. 05 |
|
|
|
|
|
------
|
|
|
|
|
|
Return to HotFixes main page
|
|
|
Return to [HotFixes](HotFixes) main page
|
|
|
|
|
|
Return to the StepByStep instructions
|
|
|
Return to the [StepByStep](StepByStep) instructions or go [home](home)
|
|
|
|
|
|
----- |